Fix error message when deleting without delete privilege #1247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…REFERENCE privilege
…ortant-bug Fix parsing SQL files
…ces-and-blank-lines Clean trailing spaces
github-actions
bot
added
enhancement
dimitri-yatsenko
requested review from
Copilot,
kushalbakshi and
ttngu207
and removed request for
kushalbakshi
There was a problem hiding this comment.
Pull Request Overview
This PR enhances error handling for cascade deletes when foreign key info is missing, updates logging calls for deprecation consistency, and ensures SQL parsing emits any trailing statements.
- Add final
yieldinparse_sqlto return residual statements. - Replace deprecated
logger.warnwithlogger.warningand adjust log messages. - Improve cascade delete error path: detect missing foreign key info and raise a clear
DataJointError.
Reviewed Changes
Copilot reviewed 3 out of 13 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| datajoint/utils.py | Yield any remaining SQL statement after parsing. |
| datajoint/table.py | Update log calls, refine cascade delete error handling, remove deprecated show_definition. |
| datajoint/autopopulate.py | Minor documentation tweaks for step numbering and signal handler comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.